-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't panic when IPv6 is not supported #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small changes. Thanks.
97eef47
to
c868554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple questions/changes, thanks!
Yes, exactly. I'm also trying to see if it could not be related to some settings in |
c868554
to
a1a9559
Compare
@tomponline As this unexpected behaviour seems to be quite different (discovery issue vs panicking) from the original issue title, should I create a new related ticket ? |
I would suggest that you keep the changes in this PR - ultimately if we cant get it working without ipv6 enabled then we need to detect that any show an error, rather than trying to proceed and then failing silently not being able to detect other members. |
@gabrielmougard also could you quote and reply to my questions rather than editing them in the future. Thanks |
@masnax do you have an idea on what could be going wrong here? I must admit that I'm running out of ideas... |
@gabrielmougard I'm not able to replicate the discovery issue with this branch myself. I've tried setting Can you provide some reproducer steps for the discoverability issue? Also, I just remembered that we will have to add permissions to the snap to allow accessing those |
@masnax should I open a new issue with a reproducer with this ipv4 discoverability issue I experience as this seems out of scope for this ticket (it is likely that my microcloud cluster is misconfigured somehow) so that we can close this one (avoiding the panicking issue) ? |
It would be great if you could file an issue with reproducer steps. I think we ought to take a look at the issue further before we go ahead and merge this. If it ends up being unrelated then we can go ahead but we should investigate first. |
a1a9559
to
2a70257
Compare
@masnax I made it work! It's been a while since I experienced the last IPv4 issue (so I don't really remember the setup steps I took), so now after following the official microcloud doc and manually disabling IPv6, I was able to get mDNS to work on IPv4 :). I updated the |
2a70257
to
eb594dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor tweaks :)
eb594dc
to
e83fdf3
Compare
@markylaing @tomponline updated |
Looks like this is going to be an issue, judging from the tests:
I'm not sure how feasible it would be to add read permissions for this path to MicroCloud. LXD probably already has it so I wonder if we could add something to |
Can you infer this from ipv6 link local addresses on the interfaces instead? |
I tried testing it locally and so far checking for the link local address seems sufficient. Given just 1 interface
It doesn't happen when setting And in all 3 cases, the link local address is indeed missing from |
089976b
to
1b75f96
Compare
@masnax @simondeziel tests should be good now :) |
42850eb
to
3eba958
Compare
@simondeziel is the DCO check no longer occurring or happening elsewhere and needs to be removed from Required checks? |
@tomponline I'll check with IS what's up with the DCO check. For this PR, I confirmed the 4 existing commits have the signed-off-by tag. |
8c60714
to
1d136ef
Compare
tests working now (except the usual timeouts in some interactive tests) |
2ebc66a
to
1ab3a7f
Compare
In case of mDNS discovery issue (no IPv6 support on a node for example), the timeout never seems to occur leading to wait forever. This should fix the issue Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…overlay networking solution is available Signed-off-by: Gabriel Mougard <[email protected]>
1ab3a7f
to
5a35009
Compare
… disabled Signed-off-by: Gabriel Mougard <[email protected]>
5a35009
to
8f91864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is 1 change here that needs to be made, particularly checking if FAN would be supported on all systems and not just the local system before proceeding.
But I can add that in the refactor PR, so this one can be merged as-is.
closes #159
hashicorp/mdns
to avoid panicking if IPv6 is not supported,lookupPeers
function.